Skip to content

Conversation

@markharwood
Copy link
Contributor

CappedScoreQuery was missing visit(QueryVisitor visitor) delegation to wrapped query.
Closes #53699

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Highlighting)

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markharwood markharwood merged commit 9f0562b into elastic:master Mar 18, 2020
markharwood added a commit to markharwood/elasticsearch that referenced this pull request Mar 18, 2020
markharwood added a commit that referenced this pull request Mar 18, 2020
CappedScoreQuery was not delegating queryVisitor calls

Closes #53699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight for Pinned Query not Working

5 participants