Use set-based interface for NodesStatsRequest #53637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamrandolph
added
>non-issue
:Core/Infra/Plugins
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
rjernst
reviewed
Mar 23, 2020
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
A couple minor questions/suggestions
server/src/main/java/org/elasticsearch/action/admin/cluster/node/stats/NodesStatsRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/node/stats/NodesStatsRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/node/stats/NodesStatsRequest.java
Outdated
Show resolved
Hide resolved
williamrandolph
added a commit
that referenced
this pull request
Mar 26, 2020
The NodesStatsRequest class uses a set of strings for its internal
serialization. This commit updates the class's interface so that we
no longer use hard-coded getters and setters, but rather
methods that add strings directly. For example, the old way of
adding "os" metrics to a request would be to call request.os(true).
The new way of doing this is to call request.addMetric("os").
For the time being, the canonical list of metrics is an enum in
NodesStatsRequest. This will eventually be replaced with something
pluggable.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the NodesStatsRequest object towards pluggability. It has the same basic structure as a similar refactor of the NodesInfoRequest object.
Now that the
NodesStatsRequestclass uses a set of strings for its internal serialization, we need to update the class's interface so that we no longer use hard-coded getters and setters, but rather methods that add strings directly. For example, the old way of adding "os" metrics to a request would be to callrequest.os(true). The new way of doing this is to callrequest.addMetric("os").For the time being, the canonical list of metrics is an enum in
NodesStatsRequest. This will eventually be replaced with something pluggable.Note that the
NodesStatsRequestBuilderclass also needs to be refactored, but I'm leaving that for a later PR in order to keep the diff manageable.Relates #52975 (meta issue)
Relates #53410 (parallel refactor of Nodes Info)
Relates #53235 (previous work on NodesStatsRequest)