Skip to content

Make classification evaluation metrics work when there is field mapping type mismatch #53458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2020
Merged

Make classification evaluation metrics work when there is field mapping type mismatch #53458

merged 2 commits into from
Mar 16, 2020

Conversation

@przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Mar 12, 2020 •
edited
Loading

This PR makes the comparison used in evaluation metrics more lenient.
Instead of comparing raw field values, it now compares their string representations so e.g.: actual field value "1" and predicted field value 1 are assumed the same.

Relates #53485

@przemekwitek przemekwitek force-pushed the fix_overall_accuracy branch 2 times, most recently from b75cbbe to b05927c Compare March 12, 2020 14:32
@przemekwitek przemekwitek changed the title Make accuracy evaluation metric work when there is field mapping type mismatch Make classification evaluation metrics work when there is field mapping type mismatch Mar 12, 2020
@przemekwitek przemekwitek mentioned this pull request Mar 12, 2020
Closed
@przemekwitek przemekwitek removed the WIP label Mar 12, 2020
@przemekwitek przemekwitek marked this pull request as ready for review March 12, 2020 14:41
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 12, 2020

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek force-pushed the fix_overall_accuracy branch from b05927c to 8e66ea3 Compare March 16, 2020 08:47
benwtrent
benwtrent approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming suggestion. But looks good.

@przemekwitek przemekwitek merged commit 4bfe288 into elastic:master Mar 16, 2020
@przemekwitek przemekwitek deleted the fix_overall_accuracy branch March 16, 2020 13:11
@przemekwitek przemekwitek mentioned this pull request Mar 16, 2020
Merged
przemekwitek added a commit that referenced this pull request Mar 16, 2020
@przemekwitek
[7.x] Make classification evaluation metrics work when there is field…
376b2ae 
… mapping type mismatch (#53458) (#53601)
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees

No one assigned

Labels

>bug :ml Machine learning v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@przemekwitek @elasticmachine @benwtrent @jakelandis