Skip to content

Conversation

@jakelandis
Copy link
Contributor

This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explictly configured.

related #52114
fixes #53183


Note - this is how I tested

# from elasticsearch directory
./gradlew :build-tools:publishToMavenLocal

./gradlew :rest-api-spec:publishToMavenLocal :test:framework:publishToMavenLocal :server:publishToMavenLocal :libs:elasticsearch-core:publishToMavenLocal :libs:elasticsearch-x-content:publishToMavenLocal :libs:elasticsearch-cli:publishToMavenLocal :libs:elasticsearch-nio:publishToMavenLocal :libs:elasticsearch-geo:publishToMavenLocal :libs:elasticsearch-secure-sm:publishToMavenLocal :distribution:archives:integ-test-zip:publishToMavenLocal :client:rest:publishToMavenLocal :client:sniffer:publishToMavenLocal :test:logger-usage:publishToMavenLocal


We can use @spinscale 's cookie cutter to help create a test project

# requires python3
pip3 install cookiecutter
cookiecutter gh:spinscale/cookiecutter-elasticsearch-ingest-processor
# Add the master version when it asks: elasticsearch_version [7.6.1]: 8.0.0-SNAPSHOT
cd ingest-awesome
# Add to the build.gradle
repositories {
   mavenLocal()
}
./gradlew check 

This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explictly configured.

related elastic#52114
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on naming, otherwise LGTM.

@jakelandis jakelandis merged commit 484372a into elastic:master Mar 5, 2020
@jakelandis jakelandis deleted the fix_53183 branch March 5, 2020 22:15
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Mar 5, 2020
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related elastic#52114
fixes elastic#53183
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Mar 5, 2020
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related elastic#52114
fixes elastic#53183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin development - extra REST tests are executed

3 participants