Fix inaccurate total hit count in _search/template api #53155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaobinlong
commented
Mar 5, 2020
.../lang-mustache/src/main/java/org/elasticsearch/script/mustache/RestSearchTemplateAction.java
Show resolved
Hide resolved
...-mustache/src/main/java/org/elasticsearch/script/mustache/TransportSearchTemplateAction.java
Outdated
Show resolved
Hide resolved
jimczi
added
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
reviewed
Mar 5, 2020
There was a problem hiding this comment.
Thanks @gaobinlong , the fix looks good to me. I left some comments regarding the moving of tests to a more appropriate place (yaml rest tests).
.../lang-mustache/src/main/java/org/elasticsearch/script/mustache/RestSearchTemplateAction.java
Show resolved
Hide resolved
...-mustache/src/main/java/org/elasticsearch/script/mustache/TransportSearchTemplateAction.java
Outdated
Show resolved
Hide resolved
...-mustache/src/main/java/org/elasticsearch/script/mustache/TransportSearchTemplateAction.java
Outdated
Show resolved
Hide resolved
modules/lang-mustache/src/test/java/org/elasticsearch/script/mustache/SearchTemplateIT.java
Outdated
Show resolved
Hide resolved
...-mustache/src/main/java/org/elasticsearch/script/mustache/TransportSearchTemplateAction.java
Outdated
Show resolved
Hide resolved
|
@jimczi, thanks for your review, can you take a look at the new commit I have pushed? |
|
@elasticmachine ok to test |
|
@elasticmachine update branch |
jimczi
approved these changes
Mar 13, 2020
jimczi
pushed a commit
that referenced
this pull request
Mar 16, 2020
When 'rest_track_total_hits_as_int' is set to true, the total hits count in the response should be accurate. So we should set trackTotalHits to true if need when parsing the inline script of a search template request. Closes #52801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #52801.
The main changes are:
When 'rest_track_total_hits_as_int' is set to true, the total hits count in the response should be accurate. So we should set trackTotalHits to
trueif need when parsing the inline script of a search template request.Add some test code in MultiSearchTemplateIT and SearchTemplateIT.