Harden search context id #53143
Merged
Harden search context id #53143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Search/Search
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
|
Pinging @elastic/es-search (:Search/Search) |
|
@jimczi I looked into how we can reopen readers on other nodes in case the current node crashes. We can use commit_id or seq_id for this. However, we won't be able to utilize it until we have reader contexts as search contexts are still stateful on the master branch. I add a TODO for this. I think it's ready for review. Can you please take a look? Thank you! |
jpountz
approved these changes
Mar 9, 2020
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Mar 11, 2020
Using a Long alone is not strong enough for the id of search contexts because we reset the id generator whenever a data node is restarted. This can lead to two issues: 1. Fetch phase can fetch documents from another index 2. A scroll search can return documents from another index This commit avoids these issues by adding a UUID to SearchContexId.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Mar 11, 2020
dnhatn
added a commit
that referenced
this pull request
Mar 11, 2020
Using a Long alone is not strong enough for the id of search contexts because we reset the id generator whenever a data node is restarted. This can lead to two issues: 1. Fetch phase can fetch documents from another index 2. A scroll search can return documents from another index This commit avoids these issues by adding a UUID to SearchContexId.
dnhatn
added a commit
that referenced
this pull request
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Long alone is not strong enough for the id of search contexts because we reset the id generator whenever a data node is restarted. This can lead to two issues:
This commit avoids these issues by adding a UUID to the search context Id.