Updates to TESTING.asciidoc for REST testing #52862
Conversation
jakelandis
added
>docs
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
Pinging @elastic/es-docs (>docs) |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
One question. Otherwise LGTM.
| --------------------------------------------------------------------------- | ||
| restResources { | ||
| restApi { | ||
| includeCore '_common', 'indices', 'index', 'cluster', 'nodes', 'get', 'ingest' |
There was a problem hiding this comment.
Is the underscore prefix to "common" required?
There was a problem hiding this comment.
yeah it's required to match the pattern
This will result in a pattern match of _common*/**. The file we are matching is _common.json. The api's don't use use folders, so we could change the pattern match to be *common*.json, however the tests do use folders so those would need to stay <prefix>*/** (or the like). I figured a simple prefix match for both would be simplest to reason about, but am open to change (in a different PR)
Update documentation for: * restResources config (related elastic#52114) * call out YAML vs. Java based Rest tests * update example to use newer syntax * update example to target a test that is not skipped * provide example for bwcRest test (related elastic#52383)
Update documentation for: * restResources config (related elastic#52114) * call out YAML vs. Java based Rest tests * update example to use newer syntax * update example to target a test that is not skipped * provide example for bwcRest test (related elastic#52383)
|
I've removed the backport pending label as this looks to have been merged into 7.6 |
5 participants
Update documentation for: