Fix cacheability of repository-hdfs integ tests #52858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
approved these changes
Feb 27, 2020
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
LGTM. One optional suggestion
| nonInputProperties.systemProperty "test.hdfs-fixture.ports", path | ||
| } | ||
| classpath += files("$buildDir/fixtures") | ||
| nonInputProperties.systemProperty "test.hdfs-fixture.ports", file("$portsFileDir/ports") |
Member
There was a problem hiding this comment.
not hugely important, but the path here will be "${workingDir}/ports/ports" right? Maybe name the file "hdfsPorts" or something like that
Contributor
Author
There was a problem hiding this comment.
I've renamed this directory hdfsFixture to be most accurate.
Signed-off-by: Mark Vieira <[email protected]>
mark-vieira
added a commit
that referenced
this pull request
Feb 27, 2020
mark-vieira
added a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the
:plugins:repository-hdfsintegration test tasks are not being pulled from the cache due to changes in test fixture data directories. These directories really shouldn't be on the classpath as the only thing we need is the ports file. Due to some particularities in classpath input filtering, we can't just add the ports file itself and subsequently ignore it for the purposes if input snapshotting. So instead we copy the file to its own directory, and add the directory to the classpath. This allows us to ignore the ports file so changes won't affect the cache key.