IndexWriterConfig used in InMemoryNoOpCommitDirectory should support soft-deletes #52781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>bug
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Member
Author
|
Thanks Nhat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use the default
IndexWriterConfigduring the initialization of searchable snapshotsDirectoryinstances. ThisIndexWriterConfigis used when opening anIndexWriterthat is later committed in order to associate an empty translog with the Lucene index built from the snapshot.Since the snapshot might contain soft deletes, the
IndexWriterConfigshould also declares a soft delete field otherwise it might just fail opening some Lucene files.