Skip to content

Conversation

@romseygeek
Copy link
Contributor

Commit #52748 fixed a bug where percolate queries wrapped in a constant score
could report incorrect matches. This commit adds a test to check that it also fixes
the case where a percolate query is sorted by something other than score.

Closes #52618

@romseygeek romseygeek added >bug :Search Relevance/Percolator Reverse search: find queries that match a document v8.0.0 v7.7.0 labels Feb 25, 2020
@romseygeek romseygeek requested a review from martijnvg February 25, 2020 12:52
@romseygeek romseygeek self-assigned this Feb 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Percolator)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit dd565f3 into elastic:master Feb 26, 2020
romseygeek added a commit that referenced this pull request Feb 26, 2020
Commit #52748 fixed a bug where percolate queries wrapped in a constant score
could report incorrect matches. This commit adds a test to check that it also fixes
the case where a percolate query is sorted by something other than score.

Closes #52618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search Relevance/Percolator Reverse search: find queries that match a document v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

percolate query sorted by "_doc" is incorrectly matching date range query

4 participants