SQL: use a calendar interval for histograms over 1 month intervals #52586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search (:Search/SQL) |
matriv
reviewed
Feb 21, 2020
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java
Outdated
Show resolved
Hide resolved
matriv
reviewed
Feb 21, 2020
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java
Outdated
Show resolved
Hide resolved
matriv
approved these changes
Feb 21, 2020
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM. Left 2 minor comments.
costin
approved these changes
Feb 24, 2020
Member
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
LGTM.
Should we add 1 day as well?
Contributor
Author
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Feb 24, 2020
…lastic#52586) (cherry picked from commit 928b11a)
astefan
added a commit
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #51538.