Handle errors when evaluating if conditions in processors #52543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine update branch |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Feb 21, 2020
Contributor
|
The backport PR seems to have been merged. I'm therefore removing the backport pending label here. Please shout if this is incorrect |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Feb 27, 2020
Contributor
Author
|
I just got the 7.x backport in which was the only one remaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain ingest pipelines, any failures when evaluating the condition for an
ifclause would result in partial execution of both the success and failure handlers for the processor. This manifested as a double decrement of theingestCurrentprocessor metric which, once it went negative, could no longer be serialized as a non-negativelong.Fixes #52339.