SQL: document the use of a filter on _routing #52355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a TIP for searching using a routing key.
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-search (:Search/SQL) |
Contributor
Author
matriv
reviewed
Feb 14, 2020
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM. Nice find and addition with the _routing
From a quick look I couldn't see any change in the resulting HTML regarding the description changes, what am I missing?
Contributor
Author
|
bpintea
approved these changes
Feb 14, 2020
Contributor
the space introduced between |
matriv
approved these changes
Feb 14, 2020
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM, I guess we could backport it to 7.6 as well?
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Feb 14, 2020
* Fix "Description"s for various sections in the functions pages. * Added a TIP for searching using a routing key. * Other small polishings (cherry picked from commit 9fad0b1)
astefan
added a commit
that referenced
this pull request
Feb 14, 2020
* Fix "Description"s for various sections in the functions pages. * Added a TIP for searching using a routing key. * Other small polishings (cherry picked from commit 9fad0b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a TIP for searching using a routing key, since the
routingURL parameter is not supported in SQL.Also, polished some sections of the documentation (especially the functions ones) to fix the Description's way of being displayed.