Use thread local random for request id generation #52344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we used the secure random number generate when generating http request ids in the security AuditUtil. We do not need to be using this level of randomness for this use case. Additionally, this random number generator involves locking that blocks the http worker threads at high concurrency loads. This commit modifies this randomness generator to use our reproducible randomness generator for Elasticsearch. This generator will fall back to thread local random when used in production.
Collaborator
|
Pinging @elastic/es-security (:Security/Audit) |
Tim-Brooks
added a commit
that referenced
this pull request
Feb 18, 2020
Currently we used the secure random number generate when generating http request ids in the security AuditUtil. We do not need to be using this level of randomness for this use case. Additionally, this random number generator involves locking that blocks the http worker threads at high concurrency loads. This commit modifies this randomness generator to use our reproducible randomness generator for Elasticsearch. This generator will fall back to thread local random when used in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we used the secure random number generate when generating http
request ids in the security AuditUtil. We do not need to be using this
level of randomness for this use case. Additionally, this random number
generator involves locking that blocks the http worker threads at high
concurrency loads.
This commit modifies this randomness generator to use our reproducible
randomness generator for Elasticsearch. This generator will fall back to
thread local random when used in production.