Fix delete enrich policy bug #52179
Merged
Fix delete enrich policy bug #52179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
the
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
Member
|
Thanks @gaobinlong for opening this PR! We will be taking a look later. |
martijnvg
approved these changes
Feb 14, 2020
...h/src/main/java/org/elasticsearch/xpack/enrich/action/TransportDeleteEnrichPolicyAction.java
Show resolved
Hide resolved
Member
|
@elasticmachine test this please |
Member
|
@elasticmachine test this please |
Member
|
Hey @gaobinlong the code style check failed. Can you run |
Contributor
Author
|
@martijnvg, OK, I have done that. |
Member
|
@elasticmachine test this please |
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Feb 18, 2020
…delete index api (elastic#52179) Don't rely on the delete index api to resolve all the enrich indices for a particular enrich policy using a '[policy_name]-*' wildcard expression. With this change, the delete policy api will resolve the indices to remove and pass that directly to the delete index api. This resolves a bug, that if `action.destructive_requires_name` setting has been set to true then the delete policy api is unable to remove the enrich indices related to the policy being deleted. Closes elastic#51228
martijnvg
added a commit
that referenced
this pull request
Feb 18, 2020
…delete index api (#52448) Backport from #52179 Don't rely on the delete index api to resolve all the enrich indices for a particular enrich policy using a '[policy_name]-*' wildcard expression. With this change, the delete policy api will resolve the indices to remove and pass that directly to the delete index api. This resolves a bug, that if `action.destructive_requires_name` setting has been set to true then the delete policy api is unable to remove the enrich indices related to the policy being deleted. Closes #51228 Co-authored-by: bellengao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #51228.
The changes are:
action.destructive_requires_namecluster setting in TransportDeleteEnrichPolicyActionTests#testDeleteIsNotLocked method, ensure the test result is always correct whether the setting is set to true or not.