[Transform] HLRC tests: dump audit index to logs for better debugging #51627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
>test
Collaborator
|
Pinging @elastic/ml-core (:ml/Transform) |
davidkyle
approved these changes
Jan 29, 2020
| transformsToClean = new ArrayList<>(); | ||
| waitForPendingTasks(adminClient()); | ||
|
|
||
| // using '*' to make this lenient and do not fail if the audit index does not exist |
Member
There was a problem hiding this comment.
The same can be achieved with new searchRequest.indicesOptions(IndicesOptions.LENIENT_EXPAND_OPEN)
Author
There was a problem hiding this comment.
searchAll does a index refresh which would fail if you give it an explicit index name.
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 30, 2020
The audit index is re-created for every testrun and therefore potential useful debug information gets lost. This change reads out the audit index and logs the results, which makes them available for debugging CI issues. relates #51549
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 18, 2020
audit messages are stored in the notifications index, so audit information is lost for integration tests. This change forwards audit messages to logs, so they can help to debug issues. relates: #51627
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 18, 2020
audit messages are stored in the notifications index, so audit information is lost for integration tests. This change forwards audit messages to logs, so they can help to debug issues. relates: #51627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audit index is re-created for every testrun and therefore potential useful debug information gets
lost. This change reads out the audit index and logs the results, which makes them available for
debugging CI issues.
relates #51549
Notes: I tried to only dump the audit index on a failure(e.g. using a
TestWatcher), however that's not possible as the code always runs after the audit index has been deleted. Creating this extra logs does not seem too heavy, therefore it dumps the audit index for every test now.