Account soft-deletes in FrozenEngine #51192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
dnhatn
changed the title
jpountz
approved these changes
Jan 20, 2020
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 20, 2020
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine. Relates elastic#50775
dnhatn
added a commit
that referenced
this pull request
Jan 20, 2020
dnhatn
added a commit
that referenced
this pull request
Jan 21, 2020
dnhatn
added a commit
that referenced
this pull request
Jan 21, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine. Relates elastic#50775
dnhatn
added a commit
that referenced
this pull request
Jan 23, 2020
IndexWriter might not filter out fully deleted segments if retention leases exist or the number of the retaining operations is non-zero. SoftDeletesDirectoryReaderWrapper, however, always filters out fully deleted segments. This change uses the original directory reader when calculating segment stats instead. Relates #51192 Closes #51303
dnhatn
added a commit
that referenced
this pull request
Jan 23, 2020
IndexWriter might not filter out fully deleted segments if retention leases exist or the number of the retaining operations is non-zero. SoftDeletesDirectoryReaderWrapper, however, always filters out fully deleted segments. This change uses the original directory reader when calculating segment stats instead. Relates #51192 Closes #51303
dnhatn
added a commit
that referenced
this pull request
Jan 23, 2020
IndexWriter might not filter out fully deleted segments if retention leases exist or the number of the retaining operations is non-zero. SoftDeletesDirectoryReaderWrapper, however, always filters out fully deleted segments. This change uses the original directory reader when calculating segment stats instead. Relates #51192 Closes #51303
dnhatn
added a commit
that referenced
this pull request
Jan 23, 2020
IndexWriter might not filter out fully deleted segments if retention leases exist or the number of the retaining operations is non-zero. SoftDeletesDirectoryReaderWrapper, however, always filters out fully deleted segments. This change uses the original directory reader when calculating segment stats instead. Relates #51192 Closes #51303
dnhatn
added a commit
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine.
Relates #50775