Test concurrent cloning/slicing of IndexInputs #51032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We test the behaviour of an `IndexInput` using `randomReadAndSlice()` which uses a wide varity of different access methods to read the data. Lucene sometimes calls `clone()` and `slice()` concurrently, although it does ensure that there are no concurrent readers while these are being called. Today we do not verify that our `IndexInput`s behave correctly under this kind of concurrent access. This commit extracts `randomReadAndSlice()` into a separate test harness for more general consumption and adds support for concurrent cloning and slicing.
DaveCTurner
added
>non-issue
:Distributed Indexing/Store
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Store) |
…urrent-cloning-of-IndexInputs
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/1 |
…urrent-cloning-of-IndexInputs
tlrx
approved these changes
Jan 16, 2020
Member
tlrx
left a comment
tlrx
left a comment
There was a problem hiding this comment.
LGTM, this is a nice addition to the tests, thanks David
DaveCTurner
deleted the
2020-01-15-test-concurrent-cloning-of-IndexInputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test the behaviour of an
IndexInputusingrandomReadAndSlice()whichuses a wide varity of different access methods to read the data. Lucene
sometimes calls
clone()andslice()concurrently, although it does ensurethat there are no concurrent readers while these are being called. Today we do
not verify that our
IndexInputs behave correctly under this kind ofconcurrent access.
This commit extracts
randomReadAndSlice()into a separate test harness formore general consumption and adds support for concurrent cloning and slicing.