Remove the 'local' parameter of /_cat/nodes #50594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in elastic#50499 and this commit removes it. Relates elastic#50088
DaveCTurner
added
>breaking
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
Just two small questions about the tests :)
server/src/main/java/org/elasticsearch/rest/action/cat/RestNodesAction.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/rest/action/cat/RestNodesActionTests.java
Show resolved
Hide resolved
original-brownbear
approved these changes
Jan 6, 2020
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
So we get a compile error when we move to v9 and drop the v7 version constants.
Fair point, that's a good enough answer to the other question then as well :) => LGTM
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The cat nodes API performs a `ClusterStateAction` then a `NodesInfoAction`. Today it accepts the `?local` parameter and passes this to the `ClusterStateAction` but this parameter has no effect on the `NodesInfoAction`. This is surprising, because `GET _cat/nodes?local` looks like it might be a completely local call but in fact it still depends on every node in the cluster. This parameter was deprecated in 7.x in elastic#50499 and this commit removes it. Relates elastic#50088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cat nodes API performs a
ClusterStateActionthen aNodesInfoAction.Today it accepts the
?localparameter and passes this to theClusterStateActionbut this parameter has no effect on theNodesInfoAction.This is surprising, because
GET _cat/nodes?locallooks like it might be acompletely local call but in fact it still depends on every node in the
cluster.
This parameter was deprecated in 7.x in #50499 and this commit removes it.
Relates #50088