Fix IndexLifecycleExplainResponse serialization version checks #48754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the version checks to use 7.6.0 instead of 8.0.0 since the changes in elastic#48256 were backported to the 7.x branch.
dakrone
added
>non-issue
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
gwbrown
approved these changes
Oct 31, 2019
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
LGTM. Serialization is hard.
Contributor
|
Thanks for fixing this @dakrone |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 I opened #48767 for the failure |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Oct 31, 2019
This was fixed by elastic#48754 Revert "Muted 'mixed_cluster/70_ilm/Test Set Policy On Index' test" This reverts commit ef22ddb. Resolves elastic#48749
dakrone
added a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the version checks to use 7.6.0 instead of 8.0.0 since the
changes in #48256 were backported to the 7.x branch.