Update oauth2-oidc-sdk and nimbus-jose-jwt #48537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update two dependencies for our OpenID Connect realm implementation to their latest versions
jkakavas
added
>non-issue
:Security/Security
Collaborator
|
Pinging @elastic/es-security (:Security/Security) |
Contributor
|
LGTM. |
bizybot
approved these changes
Oct 29, 2019
| testCompile('org.apache.kerby:kerb-util:1.1.1') | ||
| testCompile('org.apache.kerby:token-provider:1.1.1') | ||
| testCompile('com.nimbusds:nimbus-jose-jwt:4.41.2') | ||
| testCompile('com.nimbusds:nimbus-jose-jwt:8.2') |
Contributor
There was a problem hiding this comment.
just a comment: that was huge drift 4.x to 8.x and did not break anything 👍
Contributor
Author
There was a problem hiding this comment.
mostly enhancements and not so many breaking changes. Plus I doubt minikdc (kerby) makes use of much from thejose-jwt package eitherway. Mostly, I was just happy it worked :D
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Oct 29, 2019
Update two dependencies for our OpenID Connect realm implementation to their latest versions
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Oct 29, 2019
Update two dependencies for our OpenID Connect realm implementation to their latest versions
jkakavas
added a commit
that referenced
this pull request
Oct 29, 2019
jkakavas
added a commit
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update two dependencies for our OpenID Connect realm implementation
to their latest versions.