Remove Obsolete ShardGenerations BwC Logic #48416
Conversation
With elastic#48371 merged there is no need to keep the BwC logic for writing snapshots in the old style. The only thing necessary to retain is the `SnapshotsInProgress.Entry` serialization BwC.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
Jenkins run elasticsearch-ci/bwc (failed to build only) |
|
Jenkins run elasticsearch-ci/default-distro (random build stuff) |
|
@elasticmachine update branch |
| } else { | ||
| useShardGenerations = false; | ||
| final Version version = in.getVersion(); | ||
| if (version.before(Version.V_8_0_0) && version.onOrAfter(SnapshotsService.SHARD_GEN_IN_REPO_DATA_VERSION)) { |
There was a problem hiding this comment.
given that this logic can only be removed in 9.0, perhaps simpler to just unconditionally do a in.readBoolean(); here and add an assertion that fails once we branch 9.0. Also note that version.onOrAfter(SnapshotsService.SHARD_GEN_IN_REPO_DATA_VERSION) should be unnecessary once we stop testing master against 7.5. This is also why I prefer to wait with PRs like this until that has happened, it simplifies the BWC conditions.
There was a problem hiding this comment.
This is also why I prefer to wait with PRs like this until that has happened, it simplifies the BWC conditions.
Right that's a fair point. I'll just close here then and look into this again once 7.6 is out :)
3 participants
With #48371 merged there is no need to keep the BwC logic
for writing snapshots in the old style.
The only thing necessary to retain is the
SnapshotsInProgress.Entryserialization BwC.