[DOCS] Reformat CJK bigram and CJK width token filter docs #48210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
Collaborator
|
Pinging @elastic/es-search (:Search/Analysis) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
romseygeek
approved these changes
Oct 21, 2019
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
I left one comment but it's a great improvement over all. LGTM.
Comment on lines
7
to
10
| Forms https://en.wikipedia.org/wiki/Bigram[bigrams] out of the CJK (Chinese, | ||
| Japanese, and Korean) terms generated by the | ||
| <<analysis-standard-tokenizer,standard tokenizer>> or the | ||
| {plugins}/analysis-icu-tokenizer.html[ICU tokenizer]. |
Contributor
There was a problem hiding this comment.
Strictly speaking, it will form bigrams from the CJK tokens produced by any tokenizer, so I'm not sure we need to refer to standard and icu here?
Contributor
Author
There was a problem hiding this comment.
Thanks @romseygeek. I removed the standard and ICU reference with cecd9bc.
jrodewig
added a commit
that referenced
this pull request
Oct 21, 2019
jrodewig
added a commit
that referenced
this pull request
Oct 21, 2019
82 tasks
jrodewig
added a commit
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformats the CJK bigram and CJK width token filter docs:
I hope to re-use this format for other token filter docs. All feedback is welcome!