Switch to debug with server=n #48188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change one needed to re-start debugging several times, as we launched multiple JVMs in debug mode. With this option the IDE has the option to re-launch and listen for connections again leading for to a more pleasant experience.
mark-vieira
approved these changes
Oct 17, 2019
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
LGTM.
FWIW, once we address #46118 we'll be able have IntellIj setup this run configuration for us on project import.
alpar-t
added a commit
that referenced
this pull request
Oct 21, 2019
Before this change one needed to re-start debugging several times, as we launched multiple JVMs in debug mode. With this option the IDE has the option to re-launch and listen for connections again leading for to a more pleasant experience.
alpar-t
added a commit
that referenced
this pull request
Oct 21, 2019
Before this change one needed to re-start debugging several times, as we launched multiple JVMs in debug mode. With this option the IDE has the option to re-launch and listen for connections again leading for to a more pleasant experience.
matriv
reviewed
Oct 21, 2019
| --------------------------------------------------------------------------- | ||
|
|
||
| This will instruct all JVMs (including any that run cli tools such as creating the keyring or adding users) | ||
| to suspend and initiate a debug connection on port incrementing from 5005. |
Contributor
There was a problem hiding this comment.
minor: double white space before the 5005.
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Oct 21, 2019
Remove extra whitespace and highlight the starting port number. Follows: elastic#48188
matriv
added a commit
that referenced
this pull request
Oct 21, 2019
Remove extra whitespace and highlight the starting port number. Follows: #48188
matriv
added a commit
that referenced
this pull request
Oct 21, 2019
matriv
added a commit
that referenced
this pull request
Oct 21, 2019
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change one needed to re-start debugging several times, as we
launched multiple JVMs in debug mode.
With this option the IDE has the option to re-launch and listen for
connections again leading for to a more pleasant experience.