Skip to content

Fix SLMSnapshotBlockingIntegTests #47841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
original-brownbear merged 1 commit into from
Oct 10, 2019
Merged

Fix SLMSnapshotBlockingIntegTests #47841

original-brownbear merged 1 commit into from
Oct 10, 2019

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Oct 10, 2019

One of the tests in this suit stops a master node,
plus we're doing other node starts in this suit.
=> the internal test cluster should be TEST and not SUITE
scoped to avoid random failures like the one in #47834

Closes #47834

@original-brownbear
Fix SLMSnapshotBlockingIntegTests
b0dc2c1 
One of the tests in this suit stops a master node,
plus we're doing other node starts in this suit.
=> the internal test cluster should be TEST and not `SUITE`
scoped to avoid random failures like the one in #47834

Closes #47834
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.5.0 labels Oct 10, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 10, 2019

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

dakrone
dakrone approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Oct 10, 2019

np @dakrone !

@original-brownbear original-brownbear merged commit 4cdc203 into elastic:master Oct 10, 2019
@original-brownbear original-brownbear deleted the 47834 branch October 10, 2019 13:58
@original-brownbear original-brownbear mentioned this pull request Oct 10, 2019
Merged
original-brownbear added a commit that referenced this pull request Oct 10, 2019
@original-brownbear
Fix SLMSnapshotBlockingIntegTests (#47841) (#47863)
48823b1 
One of the tests in this suit stops a master node,
plus we're doing other node starts in this suit.
=> the internal test cluster should be TEST and not `SUITE`
scoped to avoid random failures like the one in #47834

Closes #47834
@original-brownbear original-brownbear restored the 47834 branch August 6, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

Assignees

No one assigned

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >test Issues or PRs that are addressing/adding tests v7.5.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] SLMSnapshotBlockingIntegTests.testRetentionWhileSnapshotInProgress failing

4 participants

@original-brownbear @elasticmachine @dakrone @jakelandis