More bootstrap docs tweaks #47809
Merged
More bootstrap docs tweaks #47809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster.
DaveCTurner
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
jrodewig
reviewed
Oct 9, 2019
jrodewig
reviewed
Oct 9, 2019
jrodewig
reviewed
Oct 9, 2019
jrodewig
reviewed
Oct 9, 2019
jrodewig
reviewed
Oct 9, 2019
jrodewig
reviewed
Oct 9, 2019
docs/reference/setup/important-settings/discovery-settings.asciidoc
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Oct 9, 2019
docs/reference/setup/important-settings/discovery-settings.asciidoc
Outdated
Show resolved
Hide resolved
jrodewig
approved these changes
Oct 9, 2019
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
LGTM. Though I chiefly reviewed for grammar and writing style.
I left a few comments, but I don't consider those blocking.
jrodewig
reviewed
Oct 9, 2019
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
ywelsch
approved these changes
Oct 10, 2019
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2019
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster. Co-Authored-By: James Rodewig <[email protected]>
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2019
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster. Co-Authored-By: James Rodewig <[email protected]>
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2019
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster. Co-Authored-By: James Rodewig <[email protected]>
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2019
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster. Co-Authored-By: James Rodewig <[email protected]>
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2019
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster. Co-Authored-By: James Rodewig <[email protected]>
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2019
Clarifies not to set `cluster.initial_master_nodes` on nodes that are joining an existing cluster. Co-Authored-By: James Rodewig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies not to set
cluster.initial_master_nodeson nodes that are joiningan existing cluster.