Remove fallback for controller location #47104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the temporary controller location fallback introduced in elastic#47013. Relates elastic/ml-cpp#593
droberts195
added
>non-issue
blocker
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
Author
|
Important: do not merge this until a few days after elastic/ml-cpp#593 is merged, otherwise it will disrupt a lot of developers working on Macs. (The PR CI is green because it ran on Linux. It would have failed on Mac.) |
Author
Since elastic/ml-cpp#593 was merged 3 days ago this is no longer the case. I have run the ML native multi-node tests locally on a Mac and they passed. |
droberts195
pushed a commit
that referenced
this pull request
Oct 4, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
droberts195
pushed a commit
that referenced
this pull request
Oct 4, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
droberts195
pushed a commit
that referenced
this pull request
Nov 1, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the temporary controller
location fallback introduced in #47013.
Relates elastic/ml-cpp#593