-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Mention ip fields in the global ordinals docs. #47045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although they do not support eager_global_ordinals, ip fields use global ordinals when they are used in certain aggregations like terms. This commit also corrects a reference to the sampler aggregation.
Collaborator
|
Pinging @elastic/es-docs |
Collaborator
|
Pinging @elastic/es-search |
jimczi
approved these changes
Sep 24, 2019
Contributor
jimczi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
jtibshirani
added a commit
that referenced
this pull request
Sep 24, 2019
Although they do not support eager_global_ordinals, ip fields use global ordinals for certain aggregations like 'terms'. This commit also corrects a reference to the sampler aggregation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Search/Search
Search-related issues that do not fall into other categories
v6.8.0
v7.0.0
v7.1.0
v7.2.0
v7.3.0
v7.4.0
v7.5.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although they do not support
eager_global_ordinals,ipfields use globalordinals for certain aggregations like
terms.This commit also corrects a reference to the
sampleraggregation.