-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Transform] rename data frame transform to transform for hlrc client #46933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hendrikmuhs
merged 12 commits into
elastic:master
from
hendrikmuhs:rename-to-transform-hlrc
Sep 25, 2019
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dfa017e
rename data frame transform to transform for hlrc client
b20f2e1
adapt tests
01d1154
update rest specs
417b0c9
rename API in reference docs
a3761a4
rename rest api spec files
d05490c
rename rest tests
636aa95
fix client usage in transform IT's
fb78a4b
rename transform IT
868e4e6
fix doc build
3618694
adapt bwc tests
d57bd94
indentation
dc45779
Merge branch 'master' into rename-to-transform-hlrc
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164 changes: 82 additions & 82 deletions
164
...elasticsearch/client/DataFrameClient.java → ...elasticsearch/client/TransformClient.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |||||
|
|
||||||
| package org.elasticsearch.client.transform; | ||||||
|
|
||||||
| import org.elasticsearch.client.transform.transforms.DataFrameTransformConfig; | ||||||
| import org.elasticsearch.client.transform.transforms.TransformConfig; | ||||||
| import org.elasticsearch.common.Nullable; | ||||||
| import org.elasticsearch.common.ParseField; | ||||||
| import org.elasticsearch.common.xcontent.ConstructingObjectParser; | ||||||
|
|
@@ -31,7 +31,7 @@ | |||||
| import static org.elasticsearch.common.xcontent.ConstructingObjectParser.constructorArg; | ||||||
| import static org.elasticsearch.common.xcontent.ConstructingObjectParser.optionalConstructorArg; | ||||||
|
|
||||||
| public class GetDataFrameTransformResponse { | ||||||
| public class GetTransformResponse { | ||||||
|
|
||||||
| public static final ParseField TRANSFORMS = new ParseField("transforms"); | ||||||
| public static final ParseField INVALID_TRANSFORMS = new ParseField("invalid_transforms"); | ||||||
|
|
@@ -42,28 +42,28 @@ public class GetDataFrameTransformResponse { | |||||
| new ConstructingObjectParser<>("invalid_transforms", true, args -> new InvalidTransforms((List<String>) args[0])); | ||||||
|
|
||||||
| @SuppressWarnings("unchecked") | ||||||
| static final ConstructingObjectParser<GetDataFrameTransformResponse, Void> PARSER = new ConstructingObjectParser<>( | ||||||
| "get_data_frame_transform", true, args -> new GetDataFrameTransformResponse( | ||||||
| (List<DataFrameTransformConfig>) args[0], (int) args[1], (InvalidTransforms) args[2])); | ||||||
| static final ConstructingObjectParser<GetTransformResponse, Void> PARSER = new ConstructingObjectParser<>( | ||||||
| "get_transform", true, args -> new GetTransformResponse( | ||||||
| (List<TransformConfig>) args[0], (int) args[1], (InvalidTransforms) args[2])); | ||||||
| static { | ||||||
| // Discard the count field which is the size of the transforms array | ||||||
| INVALID_TRANSFORMS_PARSER.declareInt((a, b) -> {}, COUNT); | ||||||
| INVALID_TRANSFORMS_PARSER.declareStringArray(constructorArg(), TRANSFORMS); | ||||||
|
|
||||||
| PARSER.declareObjectArray(constructorArg(), DataFrameTransformConfig.PARSER::apply, TRANSFORMS); | ||||||
| PARSER.declareObjectArray(constructorArg(), TransformConfig.PARSER::apply, TRANSFORMS); | ||||||
| PARSER.declareInt(constructorArg(), COUNT); | ||||||
| PARSER.declareObject(optionalConstructorArg(), INVALID_TRANSFORMS_PARSER::apply, INVALID_TRANSFORMS); | ||||||
| } | ||||||
|
|
||||||
| public static GetDataFrameTransformResponse fromXContent(final XContentParser parser) { | ||||||
| return GetDataFrameTransformResponse.PARSER.apply(parser, null); | ||||||
| public static GetTransformResponse fromXContent(final XContentParser parser) { | ||||||
| return GetTransformResponse.PARSER.apply(parser, null); | ||||||
| } | ||||||
|
|
||||||
| private List<DataFrameTransformConfig> transformConfigurations; | ||||||
| private List<TransformConfig> transformConfigurations; | ||||||
| private int count; | ||||||
| private InvalidTransforms invalidTransforms; | ||||||
|
|
||||||
| public GetDataFrameTransformResponse(List<DataFrameTransformConfig> transformConfigurations, | ||||||
| public GetTransformResponse(List<TransformConfig> transformConfigurations, | ||||||
| int count, | ||||||
| @Nullable InvalidTransforms invalidTransforms) { | ||||||
|
||||||
| @Nullable InvalidTransforms invalidTransforms) { | |
| @Nullable InvalidTransforms invalidTransforms) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#nit indention fix.