SQL: Properly handle indices with no/empty mapping#46775
Merged
costin merged 2 commits intoelastic:masterfrom Sep 17, 2019
Merged
SQL: Properly handle indices with no/empty mapping#46775costin merged 2 commits intoelastic:masterfrom
costin merged 2 commits intoelastic:masterfrom
Conversation
When encountering only indices with empty mapping, the IndexResolver throws an exception as it expects to find at least one entry. This commit fixes this case so that an empty mapping is returned. Fix elastic#46757
Collaborator
|
Pinging @elastic/es-search |
astefan
approved these changes
Sep 17, 2019
| Map<String, FieldCapabilities> types = entry.getValue(); | ||
|
|
||
| // ignore size added by the mapper plugin | ||
| // ignore size added by the mapper plugin or indices with no mapping |
Contributor
There was a problem hiding this comment.
Why "indices with no mapping" would be applicable to this condition? (the _size field, when enabled, will be added even if the mapping doesn't have any explicitly defined fields).
Member
Author
There was a problem hiding this comment.
You're right - the location of the comment is incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering only indices with empty mapping, the IndexResolver
throws an exception as it expects to find at least one entry.
This commit fixes this case so that an empty mapping is returned.
Fix #46757