Testclusters fix bwc #46740
Merged
Testclusters fix bwc #46740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements fixes and adds a test to veryfy that testclusters can start up clusters on old versions. It also serves as a tool to be able to check changes on master before backporting to aid in discovering issues earlier. TODO: - check with multi node clusters - Add integ test distro
This is required in order to backport changes, so that testclsuters works with older version of ES.
Closed
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 and run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
mark-vieira
approved these changes
Sep 17, 2019
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Changes look ok to me. @rjernst might have more to say since it involves a lot of distribution handling stuff.
buildSrc/src/main/java/org/elasticsearch/gradle/ElasticsearchDistribution.java
Show resolved
Hide resolved
Contributor
Author
|
@rjernst please take a look, this is blocking the back-port to |
rjernst
approved these changes
Sep 30, 2019
| } else { | ||
| node.defaultConfig.put("discovery.zen.master_election.wait_for_joins_timeout", "5s"); | ||
| if (nodes.size() > 1) { | ||
| node.defaultConfig.put("discovery.zen.minimum_master_nodes", nodes.size() / 2 + 1 + ""); |
Member
There was a problem hiding this comment.
nit: please just use Integer.toString instead of relying on concatenation to do conversion
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Oct 1, 2019
Additions to make testclsuters work with lather versions of ES
alpar-t
added a commit
that referenced
this pull request
Oct 2, 2019
* Add support for bwc for testclusters and convert full cluster restart (#45374) * Testclusters fix bwc (#46740) Additions to make testclsuters work with lather versions of ES * Do common node config on bwc tests Before this PR we always ever ran `ElasticsearchCluster.start` once, and the common node config was never done. This becomes apparent in upgrading from `6.x` to `7.x` as the new config is missing preventing the cluster from starting. * Do common node config on bwc tests Before this PR we always ever ran `ElasticsearchCluster.start` once, and the common node config was never done. This becomes apparent in upgrading from `6.x` to `7.x` as the new config is missing preventing the cluster from starting. * Fix logic to pick up snapshot from 6.x * Make sure ports are cleared * Fix test * Don't clear all the config as we rely on it * Fix removal of keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to back-port #45654 it was discovered that the distribution download and test clusters plugins need some tweaks to make them work with older versions of es.