-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Add support to testclusters for older versions of elasticsearch #46672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR implements fixes and adds a test to veryfy that testclusters can start up clusters on old versions. It also serves as a tool to be able to check changes on master before backporting to aid in discovering issues earlier. TODO: - check with multi node clusters - Add integ test distro
|
Pinging @elastic/es-core-infra |
|
This seems like overkill to me. I don't think we should be referencing 6.x versions in master; it would be yet another thing that has to be updated on major version bumps. And bwc tests should be run when backporting if the change affects bwc. Perhaps we need a label to trigger full bwc tests like we have for packaging? It also seems like some of these deficiencies here could be caught by better testing within build-tools. |
|
I think I need some more context on this. Perhaps we should sync up and discuss. |
|
I do think we need a full integration test for things like elasticsearch settings and access patterns for distributions, these are hard to mock and the value of the test is reduced because it doesn't verify assumptions we make when implementing. The |
|
#45654 is the backport that needs these changes first. @elasticmachine run elasticsearch-ci/1 adn run elasticsearch-ci/bwc |
|
Perhaps we can split out the smoke test bit and just have the stuff needed to backport the BWC changes to 7.x. We can then separately discuss the test coverage issue w/o holding up those backport changes. |
|
Thanks @mark-vieira that's a great idea, I'll do that |
I ran into trouble while back-porting some of the recent bwc changes, so decided to add this test that would make sure we can start all bwc versions of elasticsearch.
For now it will only run as part of
bwcTestso it doesn't add additional time to intake or PRs.This revealed some changes that were required to be able to have clusters running on older versions. Some of these will not be encountered in master but since they don't add too much complexit, I think it would be better to have them and make back-ports easier.
One added benefit of this test is that we check that testclusters actually started the version and flavor we tell it to.