Skip to content

Conversation

@pcsanwald
Copy link
Contributor

6.8.3 release notes.

@pcsanwald pcsanwald added >docs General docs changes >non-issue v6.8.3 labels Aug 29, 2019
@pcsanwald pcsanwald requested review from debadair and lcawl August 29, 2019 20:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

* Use system context for looking up connected nodes {pull}43991[#43991] (issue: {issue}43974[#43974])

Machine Learning::
* [DOCS] Adds allow no datafeeds query param to the GET, GET stats and STOP datafeed APIs (7.2-6.1) {pull}44864[#44864]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be omitted. I've added the >docs label to the PR

@lcawl lcawl mentioned this pull request Aug 29, 2019
15 tasks
* Include leases in error message when operations no longer available {pull}45681[#45681]

Infra/Core::
* Add OCI annotations and adjust existing annotations {pull}45167[#45167] (issues: {issue}45162[#45162], {issue}45166[#45166])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 45162 and 45166 are related PRs, not issues.

* Ensure AsyncTask#isScheduled remain false after close {pull}45687[#45687] (issue: {issue}45576[#45576])

Engine::
* Handle delete document level failures {pull}46100[#46100] (issue: {issue}46083[#46083])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, I think 46083 is a related PR, not an issue fixed by 46100

* Handle no-op document level failures {pull}46083[#46083]

Features/Indices APIs::
* Check shard limit after applying index templates {pull}44619[#44619] (issues: {issue}34021[#34021], {issue}44567[#44567], {issue}44619[#44619])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, I think 34021 is just a related PR not a fixed issue.
The 44619 also appears twice here--once as a PR and once as an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the script is treating all "Relates" and "Supersedes" references as issues. (The duplicate entry is because the Supersedes reference is referencing the same PR.)

* Add rest_total_hits_as_int in HLRC's search requests {pull}46076[#46076] (issue: {issue}43925[#43925])

Infra/Core::
* Add default CLI JVM options {pull}44545[#44545] (issues: {issue}219[#219], {issue}42021[#42021])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that #219 is unrelated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a reference to an issue in elasticsearch-docker.

@nik9000
Copy link
Member

nik9000 commented Aug 29, 2019

@elasticmachine, run elasticsearch-ci/docs

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the xref weirdness that @lcawl caught.

* Add rest_total_hits_as_int in HLRC's search requests {pull}46076[#46076] (issue: {issue}43925[#43925])

Infra/Core::
* Add default CLI JVM options {pull}44545[#44545] (issues: {issue}219[#219], {issue}42021[#42021])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a reference to an issue in elasticsearch-docker.

* Handle no-op document level failures {pull}46083[#46083]

Features/Indices APIs::
* Check shard limit after applying index templates {pull}44619[#44619] (issues: {issue}34021[#34021], {issue}44567[#44567], {issue}44619[#44619])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the script is treating all "Relates" and "Supersedes" references as issues. (The duplicate entry is because the Supersedes reference is referencing the same PR.)

@pcsanwald
Copy link
Contributor Author

@lcawl @debadair thanks for your contributions and review, I was quite ill on Friday so that's why I was radio silent. Will review and update according to your comments.

@pcsanwald pcsanwald requested a review from lcawl September 3, 2019 20:49
@pcsanwald
Copy link
Contributor Author

@lcawl thanks for your review, I believe I've addressed your comments, mind having another look?

I think you and @debadair are right that release notes script is indeed including "relates" PRs as issues, I'll look into this.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcsanwald I didn't click every link, but it LGTM. Hope you're feeling better!

@pcsanwald pcsanwald merged commit 09fbf09 into elastic:6.8 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes >non-issue v6.8.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants