Skip to content

Do sync before closeIntoReader when rolling generation to improve index performance #45765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Do sync before closeIntoReader when rolling generation to improve index performance #45765

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
624729e
Merge pull request #1 from elastic/master
dengweisysu Aug 21, 2019
9986233
do sync before closeIntoReader to make sure we move most of the data …
dengweisysu Aug 21, 2019
96e9741
modify comments in Translog.rollGeneration
dengweisysu Aug 21, 2019
113625b
Merge branch 'master' into master
elasticmachine Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/src/main/java/org/elasticsearch/index/translog/Translog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,6 +1641,10 @@ public TranslogGeneration getMinGenerationForSeqNo(final long seqNo) {
* @throws IOException if an I/O exception occurred during any file operations
*/
public void rollGeneration() throws IOException {
//make sure we move most of the data to disk outside of the writeLock
//and then the time the lock is held can be reduced
sync();

try (Releasable ignored = writeLock.acquire()) {
try {
final TranslogReader reader = current.closeIntoReader();
Expand Down