Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Aug 12, 2019

This commit updates the search example to use snake casing for the document field. This is consistent with other examples

This commit updates the search example to use snake casing for the document field. This is consistent with other examples
@ebadyano ebadyano added :Docs >docs General docs changes labels Aug 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this @russcam.

@russcam
Copy link
Contributor Author

russcam commented Aug 13, 2019

No worries @jrodewig. Which branches would you like me to backport the commit to?

@jrodewig
Copy link
Contributor

@russcam We typically backport to the last supported branch. That's currently 6.8.

@javanna javanna merged commit 961f69e into master Sep 19, 2019
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
javanna pushed a commit that referenced this pull request Sep 19, 2019
This commit updates the search example to use snake casing for the document field. This is consistent with other examples
@jrodewig
Copy link
Contributor

Thanks @javanna!

@jrodewig jrodewig deleted the russcam-patch-15 branch September 19, 2019 12:33
@colings86 colings86 added v7.4.0 and removed v7.4.1 labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants