Skip to content

Conversation

@szabosteve
Copy link
Contributor

Relates to elastic/docs#937 and #45197.

This PR updates the cluster update settings API to align with the new API reference template.

Resources:

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's currently documented together and uses the same resources, I think we should split this one into two API pages:

  • Get cluster settings
  • Update cluster settings

We can model this off of the rollup jobs APIs:

@szabosteve
Copy link
Contributor Author

@jrodewig e6f59dd addresses your feedback.

@jrodewig
Copy link
Contributor

@szabosteve This looks good.

We need to add the new update-settings.asciidoc file to cluster.asciidoc so it'll show up in the nav.

@szabosteve
Copy link
Contributor Author

szabosteve commented Aug 13, 2019

@jrodewig Both update-settings.asciidoc and get-settings.asciidoc have been already added to cluster.asciidoc and they are shown in the nav.

https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster.html

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @szabosteve.

@szabosteve szabosteve merged commit 2697316 into elastic:master Aug 13, 2019
@szabosteve szabosteve deleted the reformat.cluster.update branch August 13, 2019 12:22
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Aug 13, 2019
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Aug 13, 2019
@szabosteve
Copy link
Contributor Author

Backported to 7.x and 7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants