Avoid dumping the heap in Painless tests #44782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, we have a test here that intentionally causes an OutOfMemoryError, to ensure that Painless handles it (I still strongly disagree with doing this). This causes two things to happen: an OutOfMemoryError to be dumped to the console, and the heap to be dumped to disk. This makes it look like we had an OutOfMemoryError while running tests, and the tests did not fail properly. This commit changes the tests configuration so that we suppress the heap dump, which also causes the OutOfMemoryError to no longer be dumped to the console.
jasontedor
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
jasontedor
added a commit
that referenced
this pull request
Jul 24, 2019
Well, we have a test here that intentionally causes an OutOfMemoryError, to ensure that Painless handles it (I still strongly disagree with doing this). This causes two things to happen: an OutOfMemoryError to be dumped to the console, and the heap to be dumped to disk. This makes it look like we had an OutOfMemoryError while running tests, and the tests did not fail properly. This commit changes the tests configuration so that we suppress the heap dump, which also causes the OutOfMemoryError to no longer be dumped to the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, we have a test here that intentionally causes an OutOfMemoryError, to ensure that Painless handles it (I still strongly disagree with doing this). This causes two things to happen: an OutOfMemoryError to be dumped to the console, and the heap to be dumped to disk. This makes it look like we had an OutOfMemoryError while running tests, and the tests did not fail properly. This commit changes the tests configuration so that we suppress the heap dump, which also causes the OutOfMemoryError to no longer be dumped to the console.