Skip to content

Conversation

@brusic
Copy link
Contributor

@brusic brusic commented Dec 16, 2013

Lucene 4.5 provides more options for the SpanNotQuery. Not sure if to update the docs with the pull request or not. If accepted and I knew the potential elasticsearch version which might contain it, I can add the appropriate "Added in ..." message in the documentation.

@brusic
Copy link
Contributor Author

brusic commented Feb 21, 2014

Merged latest master (broke on ElasticSearch -> Elasticsearch renaming)

@brusic
Copy link
Contributor Author

brusic commented Jul 30, 2014

Will attempt to rebase soon. I will also try to incorporate the test cases from the Lucene repo

https://svn.apache.org/repos/asf/lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/spans/TestSpans.java

@clintongormley
Copy link
Contributor

Hi @brusic - just pinging to find out if you've had a chance to look at this yet.

@brusic
Copy link
Contributor Author

brusic commented Oct 21, 2014

I thought the ES crew forgot about this PR. :) I will be traveling this
week, but hopefully I can merge with master and perhaps add a few more
tests within a week.

On Mon, Oct 20, 2014 at 5:49 AM, Clinton Gormley [email protected]
wrote:

Hi @brusic https://github.com/brusic - just pinging to find out if
you've had a chance to look at this yet.


Reply to this email directly or view it on GitHub
#4452 (comment)
.

@jadetr
Copy link

jadetr commented Nov 6, 2014

+1 to Expose dist/pre/post options for SpanNotQuery

@brusic
Copy link
Contributor Author

brusic commented Nov 18, 2014

Rebased with latest master

@martijnvg
Copy link
Member

Thanks @brusic, although it took a while, it looked good and I pulled this in.

@clintongormley clintongormley changed the title Expose dist/pre/post options for SpanNotQuery Query DSL: Expose dist/pre/post options for SpanNotQuery Nov 25, 2014
@jadetr
Copy link

jadetr commented Nov 28, 2014

@brusic Thanks for this fix and the answers on ES group.

@clintongormley clintongormley changed the title Query DSL: Expose dist/pre/post options for SpanNotQuery Expose dist/pre/post options for SpanNotQuery Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Query DSL labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Search/Search Search-related issues that do not fall into other categories v1.4.1 v1.5.0 v2.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants