Convert BucketScript to static parser#44385
Merged
polyfractal merged 3 commits intoelastic:masterfrom Jul 17, 2019
Merged
Conversation
BucketScript was using the old-style parser and could easily be converted over to the newer static parser. Also adds a test for GapPolicy enum serialization
Collaborator
|
Pinging @elastic/es-analytics-geo |
Contributor
Author
|
@elasticmachine update branch |
polyfractal
pushed a commit
that referenced
this pull request
Jul 17, 2019
BucketScript was using the old-style parser and could easily be converted over to the newer static parser. Also adds a test for GapPolicy enum serialization
Member
|
We're seeing issues with Kibana that we have tracked back to this commit. Here is an example of a query throwing the exception: Is there an intentional breaking change here, or something we should be doing differently in this Timelion request? |
Contributor
|
This is not an intentional break. I have opened a PR toads back the possibility of defining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wanting to make some changes to BucketScript to support "empty" buckets, but the old style parser was getting in the way. This converts it over to the new(er) static parser. It also adds a test for GapPolicy enum serialization since that was lacking.