Skip to content

Fix InternalTestCluster StopRandomNode Assertion #44258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
original-brownbear merged 1 commit into from
Jul 12, 2019
Merged

Fix InternalTestCluster StopRandomNode Assertion #44258

original-brownbear merged 1 commit into from
Jul 12, 2019

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Jul 12, 2019 •
edited
Loading

@original-brownbear
Fix InternalTestCluster StopRandomNode Assertion
aed86ad 
* The assertion added in #44214 is tripped by tests running dedicated
test clusters per test needlessly.This breaks existing tests like the one in #44245.
* Closes #44245
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.0.0 v7.4.0 labels Jul 12, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 12, 2019

Pinging @elastic/es-distributed

DaveCTurner
DaveCTurner approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many options...

LGTM

@original-brownbear original-brownbear merged commit 31ec9ed into elastic:master Jul 12, 2019
@original-brownbear original-brownbear deleted the 44245 branch July 12, 2019 09:04
@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jul 12, 2019

thanks @DaveCTurner !

@original-brownbear original-brownbear mentioned this pull request Jul 12, 2019
Merged
original-brownbear added a commit that referenced this pull request Jul 12, 2019
@original-brownbear
Fix InternalTestCluster StopRandomNode Assertion (#44258) (#44265)
6c02cf0 
* The assertion added in #44214 is tripped by tests running dedicated
test clusters per test needlessly.This breaks existing tests like the one in #44245.
* Closes #44245
@original-brownbear original-brownbear restored the 44245 branch August 6, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

No one assigned

Labels

:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >test Issues or PRs that are addressing/adding tests v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

org.elasticsearch.action.admin.indices.shards.IndicesShardStoreRequestIT.testBasic fails reproducibly

4 participants

@original-brownbear @elasticmachine @DaveCTurner @jakelandis