[DOCS] Rewrite has_child query to use new format
#44190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-docs |
Collaborator
|
Pinging @elastic/es-search |
cbuescher
approved these changes
Jul 11, 2019
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, I left two suggestions but feel free to adress them at will.
| unique parent documents increases. Each `has_child` query in a search can | ||
| increase query time significantly. | ||
| If you care about query performance, do not use this query. If need to use the |
Member
There was a problem hiding this comment.
" If need" <- not a native speaker, but is there a verb missing? Or something else from the sentence?
Contributor
Author
There was a problem hiding this comment.
You didn't miss anything. Just a typo. Should read If you need... Fixed with 164d716.
| `false` (the default value) the query will throw an exception if the `type` | ||
| is not mapped. | ||
| `max_children`:: | ||
| (integer) Optional. Maximum number of child documents allowed for returned parent |
Member
There was a problem hiding this comment.
Reading this I was wondering if "child documents" here means child documents that match the query condition. I might have missed that part, but maybe its worth clarifying.
jrodewig
added a commit
that referenced
this pull request
Jul 11, 2019
jrodewig
added a commit
that referenced
this pull request
Jul 11, 2019
jrodewig
added a commit
that referenced
this pull request
Jul 11, 2019
jrodewig
added a commit
that referenced
this pull request
Jul 11, 2019
jrodewig
added a commit
that referenced
this pull request
Jul 11, 2019
jrodewig
added a commit
that referenced
this pull request
Jul 11, 2019
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the
has_childquery to use the new query format.This is part of #40977, an effort to standardize documentation for query types.
Before
Before image
After
After image