Skip to content

[DOCS] Add lowercase filter to phrase suggester example so searches are case insensitive #44186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrodewig merged 1 commit into from
Jul 11, 2019
Merged

[DOCS] Add lowercase filter to phrase suggester example so searches are case insensitive #44186

jrodewig merged 1 commit into from
Jul 11, 2019

Conversation

@jmorph99
Copy link
Contributor

@jmorph99 jmorph99 commented Jul 10, 2019

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@jrodewig jrodewig added the >docs General docs changes label Jul 10, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 10, 2019

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 10, 2019

Pinging @elastic/es-search

@jrodewig jrodewig changed the title Example was case sensitive, so "nike" couldn't find "Nike" [DOCS] Add lowercase filter to phrase suggester example so searches are case insensitive Jul 11, 2019
jrodewig
jrodewig approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and builds successfully.

@jrodewig jrodewig merged commit 1919c42 into 6.8 Jul 11, 2019
@jrodewig jrodewig deleted the jmorph99-patch-1 branch July 11, 2019 19:08
jrodewig pushed a commit that referenced this pull request Jul 11, 2019
@jmorph99 @jrodewig
[DOCS] Add lowercase filter to phrase suggester example so searches…
8030d8f 
… are case insensitive (#44186)
jrodewig pushed a commit that referenced this pull request Jul 11, 2019
@jmorph99 @jrodewig
[DOCS] Add lowercase filter to phrase suggester example so searches…
8f96ec6 
… are case insensitive (#44186)
jrodewig pushed a commit that referenced this pull request Jul 11, 2019
@jmorph99 @jrodewig
[DOCS] Add lowercase filter to phrase suggester example so searches…
53de123 
… are case insensitive (#44186)
jrodewig pushed a commit that referenced this pull request Jul 11, 2019
@jmorph99 @jrodewig
[DOCS] Add lowercase filter to phrase suggester example so searches…
8a5a01f 
… are case insensitive (#44186)
jrodewig pushed a commit that referenced this pull request Jul 11, 2019
@jmorph99 @jrodewig
[DOCS] Add lowercase filter to phrase suggester example so searches…
4adeabc 
… are case insensitive (#44186)
jrodewig pushed a commit that referenced this pull request Jul 11, 2019
@jmorph99 @jrodewig
[DOCS] Add lowercase filter to phrase suggester example so searches…
812fcc9 
… are case insensitive (#44186)
@jrodewig
Copy link
Contributor

jrodewig commented Jul 11, 2019 •
edited
Loading

Ported from master (8.x) to 6.8.

@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes :Search Relevance/Suggesters "Did you mean" and suggestions as you type v6.8.0 v6.8.1 v6.8.2 v7.0.2 v7.1.2 v7.2.2 v7.3.0 v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmorph99 @elasticmachine @jrodewig @jpountz @jakelandis