Reduce TestLogging usage in DisruptionIT tests #43411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only tests with annotations are those with open issues. Also adds links to the open issues in the remaining cases. Relates elastic#43403
DaveCTurner
added
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Armin I asked you to review because I removed the logging annotation on |
jasontedor
approved these changes
Jun 20, 2019
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM, however, what about the new DiskDisruptionIT that was added today. Can that be removed, now, or soon in the future?
original-brownbear
approved these changes
Jun 20, 2019
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM too, I already have all the intel I need for the open snapshot disruption IT issue (it's resolved by the snapshot cleanup logic PR). Thanks for pinging though :)
DaveCTurner
deleted the
2019-06-20-reduce-testlogging-in-disruption-tests
branch
DaveCTurner
added a commit
that referenced
this pull request
Jun 21, 2019
Removes `@TestLogging` annotations in `*DisruptionIT` tests, so that the only tests with annotations are those with open issues. Also adds links to the open issues in the remaining cases. Relates #43403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
@TestLoggingannotations in*DisruptionITtests, so that the onlytests with annotations are those with open issues. Also adds links to the open
issues in the remaining cases.
Relates #43403