Skip to content

Conversation

@cbuescher
Copy link
Member

@cbuescher cbuescher commented Jun 5, 2019

This PR adds documentation to the feature being worked on in #42888

@cbuescher cbuescher added >docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0 v7.3.0 labels Jun 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@cbuescher cbuescher requested a review from jimczi June 5, 2019 13:12
@cbuescher
Copy link
Member Author

@jimczi sorry again for messing up the previous feature branch, I transfered your comments from #42865 and hopefully addressed them with my following commit.

@cbuescher cbuescher force-pushed the reloadable-analyzers-docs branch from 6e5153c to e65ae20 Compare June 6, 2019 09:29
@cbuescher
Copy link
Member Author

Just to note, the docs checks cannot pass as long as #42888 which contains the implemention for this is merged into the feature branch. I was thinking about cherry-picking those changes here but then that would make keeping this branch up-to date more difficult, so I'm disregarding docs checks for the time being.

@cbuescher
Copy link
Member Author

@elasticmachine update branch

@cbuescher cbuescher removed the v7.3.0 label Jun 16, 2019
@cbuescher
Copy link
Member Author

@jimczi tests pass now that #42888 is merged to the feature branch. Would you mind taking another look? I'd like to merge this as well and open a PR for the whole feature branch to get final reviews there.

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits, LGTM otherwise

synonym definition. The contents of the configured synonyms file will be reloaded and the
synonyms definition the filter uses will be updated.

Note: Trying to use the above analyzer as an index analyzer will result in an error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/Note:/NOTE:/ ?


Reloads search analyzers and its resources.

The `_reload_search_analyzers` API can be run on one more indices and will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:/can be run on one more/can be run on one or more/

<1> Mark the synonym filter as updateable.
<2> Synonym analyzer is usable as a search_analyzer.

Calling the `_reload_search_analyzers` endpoint will now trigger reloading the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:s/reloading the/reloading of the/ ?

@cbuescher cbuescher merged commit ff92ad6 into elastic:reloadable-analyzers-feature Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants