-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add documentation about reloading search analyzers #42891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about reloading search analyzers #42891
Conversation
|
Pinging @elastic/es-search |
docs/reference/analysis/tokenfilters/synonym-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
6e5153c to
e65ae20
Compare
|
Just to note, the docs checks cannot pass as long as #42888 which contains the implemention for this is merged into the feature branch. I was thinking about cherry-picking those changes here but then that would make keeping this branch up-to date more difficult, so I'm disregarding docs checks for the time being. |
|
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits, LGTM otherwise
| synonym definition. The contents of the configured synonyms file will be reloaded and the | ||
| synonyms definition the filter uses will be updated. | ||
|
|
||
| Note: Trying to use the above analyzer as an index analyzer will result in an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/Note:/NOTE:/ ?
|
|
||
| Reloads search analyzers and its resources. | ||
|
|
||
| The `_reload_search_analyzers` API can be run on one more indices and will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:/can be run on one more/can be run on one or more/
| <1> Mark the synonym filter as updateable. | ||
| <2> Synonym analyzer is usable as a search_analyzer. | ||
|
|
||
| Calling the `_reload_search_analyzers` endpoint will now trigger reloading the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:s/reloading the/reloading of the/ ?
This PR adds documentation to the feature being worked on in #42888