Deprecate CommonTermsQuery and cutoff_frequency (#42619) #42691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate CommonTermsQuery and cutoff_frequency Since the max_score optimization landed in Elasticsearch 7, the CommonTermsQuery is redundant and slower. Moreover the cutoff_frequency parameter for MatchQuery and MultiMatchQuery is redundant. Relates to elastic#27096 (cherry picked from commit 04b7449)
Collaborator
|
Pinging @elastic/es-search |
jimczi
approved these changes
May 30, 2019
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
May 31, 2019
Add deprecation entries for 7.3 regarding `common` query and `cutoff_frequency` parameter. Follows: elastic#42691
matriv
added a commit
that referenced
this pull request
May 31, 2019
Add deprecation entries for 7.3 regarding `common` query and `cutoff_frequency` parameter. Follows: #42691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the max_score optimization landed in Elasticsearch 7,
the CommonTermsQuery is redundant and slower. Moreover the
cutoff_frequency parameter for MatchQuery and MultiMatchQuery
is redundant.
Relates to #37096
(cherry picked from commit 04b7449)