Throw exception if legacy interval cannot be parsed in DateIntervalWrapper #41972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fallthrough logic, DateIntervalWrapper assumed that an
otherwise unparsable interval was a legacy fixed millis interval. This
could then NPE if the interval was just illegal ("foobar").
This commit correctly checks if the legacy millis parsing fails too,
and throws an IllegalArgumentException at that point signaling the
provided interval is bad.
Collaborator
|
Pinging @elastic/es-analytics-geo |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/docbldesx |
Contributor
Author
|
Thanks @jimczi :) |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Due to the fallthrough logic, DateIntervalWrapper assumed that an
otherwise unparsable interval was a legacy fixed millis interval. This
could then NPE if the interval was just illegal ("foobar").
This commit correctly checks if the legacy millis parsing fails too,
and throws an IllegalArgumentException at that point signaling the
provided interval is bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fallthrough logic, DateIntervalWrapper assumed that an otherwise unparsable interval was a legacy fixed millis interval. This could then NPE if the interval was just illegal ("foobar").
This commit correctly checks if the legacy millis parsing fails too, and throws an IllegalArgumentException at that point signaling the provided interval is bad.
Note: Only targeting master since the 7.x backport is still WIP. I'll incorporate this fix directly into the backport.
Closes #41970