Skip to content

Conversation

@benwtrent
Copy link
Member

This bug found its way in with the refactor from: #41278

Since we are creating the indexer in the DataFrameTransformPersistentTasksExecutor and then injecting it into the task, we need to make sure that when the indexer starts executing, that it is initialized in the correct state.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs
Copy link

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test please

@benwtrent benwtrent merged commit ec2e01a into elastic:master May 2, 2019
@benwtrent benwtrent deleted the feature/ml-df-correct-task-migration-logic branch May 2, 2019 14:32
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request May 2, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants