Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 24, 2019

In the 5.x version of the Elasticsearch.Net docs, the NEST Breaking Changes page links to an auto-generated anchor in the 5.6 Elasticsearch reference.

This is bad practice generally, but the link breaks in Asciidoctor. This PR adds the anchor to Elasticsearch reference so the Elasticsearch.Net link does not break during Asciidoctor migration.

Relates to #41128 and elastic/docs#827.

@jrodewig jrodewig added >docs General docs changes :Docs labels Apr 24, 2019
@jrodewig jrodewig requested a review from nik9000 April 24, 2019 19:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig changed the title [DOCS] Specify ID for string replacement section of 5.0 breaking changes [DOCS] Specify ID for string field replacement section of 5.0 breaking changes Apr 24, 2019
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit ba449b2 into elastic:5.6 Apr 24, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors-string-mapping branch April 24, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants