Skip to content

Conversation

@przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Apr 10, 2019

…(#40967)

  • [ML] Add validation that rejects duplicate detectors in PutJobAction

Closes #39704

  • Add YML integration test for duplicate detectors fix.

  • Use "== false" comparison rather than "!" operator.

  • Refine error message to sound more natural.

  • Put job description in square brackets in the error message.

  • Use the new validation in ValidateJobConfigAction.

  • Exclude YML tests for new validation from permission tests.

…lastic#40967)

* [ML] Add validation that rejects duplicate detectors in PutJobAction

Closes elastic#39704

* Add YML integration test for duplicate detectors fix.

* Use "== false" comparison rather than "!" operator.

* Refine error message to sound more natural.

* Put job description in square brackets in the error message.

* Use the new validation in ValidateJobConfigAction.

* Exclude YML tests for new validation from permission tests.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek przemekwitek merged commit f5014ac into elastic:7.x Apr 10, 2019
@przemekwitek przemekwitek deleted the duplicate_detectors_fix-7.x branch April 10, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants