Adjust BWC candidates in retention lease BWC tests #40562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We test BWC with nodes older than 6.7.0 since such nodes would not understand retention lease sync requests. However, we do not need to test compatbility with nodes on or after 6.7.0 since we know these nodes understand retention lease sync requests, which are already exercised in other tests. Therefore, we can skip these versions when running the BWC tests and only test against versions that do not understand retention lease sync requests.
jasontedor
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
This is an alternative proposal to #40561. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test BWC with nodes older than 6.7.0 since such nodes would not understand retention lease sync requests. However, we do not need to test compatibility with nodes on or after 6.7.0 since we know these nodes understand retention lease sync requests, which are already exercised in other tests. Therefore, we can skip these versions when running the BWC tests and only test against versions that do not understand retention lease sync requests.
Closes #40559
Relates #40561